This checker is prone to throw many warnings due to the way how we implement NS_IMETHOD. Since it's very widespread across our code base we cannot change it, since in many cases it's also used in order to create vtables for the corresponding classes. I propose to eliminate since besides the semantical benefit it doesn't add nothing valuable.

Comment on attachment 8931617 [details] Bug 1420366 - remove modernize-use-override from clang-bot config. https://reviewboard.mozilla.org/r/202774/#review208088 ::: .clang-tidy:1 (Diff revision 1) > # Checks run by clang-tidy over Mozilla code. I think we are using tools/clang-tidy/config.yaml This file is probably useless now, no?

Yes that one is used for the bot, but if you run by hand clang-tidy this file will be used. OK I will drop this change and remove it from the bot config.

Comment on attachment 8931617 [details] Bug 1420366 - remove modernize-use-override from clang-bot config. https://reviewboard.mozilla.org/r/202774/#review208094

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e805540bfd7a remove modernize-use-override from clang-bot config. r=sylvestre